Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turned RequestScheduler.prioritize off for karma tests #4175

Merged
merged 2 commits into from
Aug 4, 2016

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Aug 4, 2016

From here: #3241

Fix test failures when running with Karma (makes Travis CI fail): npm run test -- --exclude WebGL --browsers Electron --failTaskOnError --suppressPassed

This disables request prioritization since it interferes with tests that expect a request to go through immediately. I made a similar fix before for jasmine tests: https://github.com/AnalyticalGraphicsInc/cesium/blob/3d-tiles/Specs/spec-main.js#L61-L62

@pjcozzi @mramato is there a better alternative here?

@mramato
Copy link
Contributor

mramato commented Aug 4, 2016

I'm OK with this change since it's the simplest solution. The only alternative would be to enabled/disable it in beforeAll/afterAll for the specific test suites that need it.

Travis is still failing because of WebGL tests that are not tagged correctly, but I assume you'll fix that in another PR?

@lilleyse
Copy link
Contributor Author

lilleyse commented Aug 4, 2016

The only test failing for me is Core/Recatangle can pack... and it's fine in master.

@mramato
Copy link
Contributor

mramato commented Aug 4, 2016

The only test failing for me is Core/Recatangle can pack... and it's fine in master.

The problem is you are running locally on a webgl enabled browser. There are 8 test failures:
https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/149837649#L937

To reproduce locally, disable WebGL in Firefox and then run the Cesium non-webgl unit tests.

@mramato
Copy link
Contributor

mramato commented Aug 4, 2016

Rectangle.pack fails because the packable interface changed recently and that function now needs to return the packed array (i.e. the result parameter). That will fix it.

@lilleyse
Copy link
Contributor Author

lilleyse commented Aug 4, 2016

To reproduce locally, disable WebGL in Firefox and then run the Cesium non-webgl unit tests.

Ah alright.

Rectangle.pack fails because the packable interface changed recently and that function now needs to return the packed array (i.e. the result parameter). That will fix it.

Rectangle.pack looks ok to me. I'm not sure why it's failing.

I fixed the other tests.

@mramato
Copy link
Contributor

mramato commented Aug 4, 2016

Thanks, I'll check out the Rectangle test and see if it's an easy fix.

@mramato mramato merged commit b076ce4 into 3d-tiles Aug 4, 2016
@mramato mramato deleted the fix-test-failures branch August 4, 2016 20:39
@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 8, 2016

@lilleyse please cherry pick this for #3476. Also merge master into that branch.

mramato added a commit that referenced this pull request Aug 8, 2016
#4175 provided an initial fix, but it doesn't work for release tests,
this works in both debug and release modes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants