Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of oblique fonts #4239

Merged
merged 2 commits into from
Aug 29, 2016
Merged

Fix handling of oblique fonts #4239

merged 2 commits into from
Aug 29, 2016

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Aug 26, 2016

Take font weight into account when measuring text width.

Note that there will still be some issues with certain fonts due to overlapping transparent billboards. That will be fixed with #2130.

Fixes #3782

This is based on some code from @GatorScott. Thanks Scott!

Take font weight into account when measuring text width.

Note that there will still be some issues with certain fonts due to
overlapping transparent billboards. That will be fixed with #2130.

Fixes #3782
@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 27, 2016

@hpinkos can you please review and merge?

@hpinkos
Copy link
Contributor

hpinkos commented Aug 29, 2016

Looks great @mramato, thanks!

@hpinkos hpinkos merged commit 1ab9c96 into master Aug 29, 2016
@hpinkos hpinkos deleted the dont-skip-leg-day branch August 29, 2016 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels with oblique or italic fonts look incorrect
3 participants