Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests that require an extension #4986

Merged
merged 2 commits into from Feb 10, 2017

Conversation

shehzan10
Copy link
Member

The following tests are skipped:

  • Scene/Primitive renders with distance display condition per instance attribute (floatingPointTextures)
  • Scene/GroundPrimitive renders with distance display condition per instance attribute (floatingPointTextures)
  • Scene/BillboardCollection renders more than 16k billboards (instancedArray)
  • Renderer/Context get the frame depth extension (frameDepth)

Fixes #4711 along with #4980.

The following tests are skipped:
* Scene/Primitive renders with distance display condition per instance attribute (floatingPointTextures)
* Scene/GroundPrimitive renders with distance display condition per instance attribute (floatingPointTextures)
* Scene/BillboardCollection renders more than 16k billboards (instancedArray)
@shehzan10
Copy link
Member Author

According to @bagnell the primitive, ground primitive, billboard collection tests should be fixed in the backend to have proper fallback. I can open a new issue for that.

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 10, 2017

According to @bagnell the primitive, ground primitive, billboard collection tests should be fixed in the backend to have proper fallback. I can open a new issue for that.

I agree that the workaround in the test is not the right place. What do you mean by "backend?" The implementation, right?

I'm not sure that we can prioritize those right now. Perhaps update #4711 with the new info and trim this down to just the Renderer/Context get the frame depth extension fix which is correct.

@shehzan10
Copy link
Member Author

I'm not sure that we can prioritize those right now. Perhaps update #4711 with the new info and trim this down to just the Renderer/Context get the frame depth extension fix which is correct.

Merging this PR and (#4980) would make #4711 failures go away. I am not seeing any more of those.

Yes, by backend I mean implementation. The proper fallback fix in the implementation can be done later (for which we can create an issue).

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 10, 2017

Yes, by backend I mean implementation. The proper fallback fix in the implementation can be done later (for which we can create an issue).

See #4988

Scene/BillboardCollection renders more than 16k billboards (instancedArray)

Are you sure this is instancing, not the uint32 extension?

@shehzan10
Copy link
Member Author

Are you sure this is instancing, not the uint32 extension?

Yes, the test passes when I explicitly set the elementIndexUint extension to false.

See #4988

So do you want me to keep the if(extension) conditions as a part of this PR?

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 10, 2017

So do you want me to keep the if(extension) conditions as a part of this PR?

Yes, I think it is OK given the issue written.

@pjcozzi pjcozzi merged commit 7f69834 into CesiumGS:master Feb 10, 2017
@shehzan10 shehzan10 deleted the extension-disable-tests branch February 10, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants