3D Tiles - Newly generated tilesets #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Just open another PR for other tilesets. Please make commits with data-only changes so we can squash them later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3241
Adds new tilesets generated from 3d-tiles-generator and some small bug fixes.
Completely new tilesets:
BatchedColorsMixBatchedColorsTranslucentBatchedWGS84- position directly in WGS84 (no RTC), only for testing purposesBatchedWithQuantization- uses gltf quantized positions, oct encoded normals, compress uvsBatchedDeprecated- has the legacy 20-byte header andBATCHIDgltf semantic instead of_BATCHID- my experience is its a lot easier to have this tileset for testing purposes than making fine-tuned tests.BatchedNoBuildingsrenamed toBatchedNoBatchIdsInstancedWithBatchIds- some of the old tileset hadBATCH_IDin the feature table, now this is the only one. This will be helpful for #4987It's fine if this PR parks in here for a few days in case I notice other needed updates.