3D Tiles - Specify glTF up-axis in tileset.json #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmconne this is for design models. |
|
Looks OK to me, can you open a PR for the spec? I'm not 100% sure this should be a top-level property (per tile seems like overkill especially since external tilesets could be used), but I wonder if it belongs under |
|
|
|
@lilleyse let me know when this is ready. |
|
@pjcozzi Could you look at the spec PR first - CesiumGS/3d-tiles#182 If that seems ok I'll update here. |
|
@lilleyse please bump when ready. |
|
This is ready. |
lilleyse
commented
Mar 8, 2017
| @@ -159,6 +159,8 @@ define([ | |||
| if (picked instanceof Cesium3DTileFeature) { | |||
| that._feature = picked; | |||
| that._updateStats(true); | |||
| } else { | |||
| that._feature = undefined; | |||
There was a problem hiding this comment.
I noticed that features weren't being unselected due to changes in #5081, so this is a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3241
For CesiumGS/3d-tiles#175
Merge after #5004
Adds support for a
gltfUpAxisproperty intileset.jsonthat may be"X","Y", or"Z", and passes the axis toModel(building upon #4962). By default thegltfUpAxisis"Y"since the glTF spec states that models are y-up.