Normal generation errors #5032
Merged
Normal generation errors #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er degenerate or part of coplanar triangles with opposite winding order.
bagnell
reviewed
Feb 24, 2017
Source/Core/GeometryPipeline.js
Outdated
| normalValues[i3 + 2] = 1.0; | ||
|
|
||
| // We can run into an issue where a vertex is used with 2 primitives that have opposite winding order. | ||
| if (Cartesian3.equals(Cartesian3.ZERO, normal)) { |
There was a problem hiding this comment.
You might have more than 2 triangles. Would a better test be to only add a normal if its dot product with the sum is greater than zero?
There was a problem hiding this comment.
Actually, never mind. I can think of some geometries that Cesium can generate where this wouldn't be true. Also, add an epsilon check here.
bagnell
reviewed
Feb 24, 2017
Source/Core/GeometryPipeline.js
Outdated
| } | ||
|
|
||
| // We end up with a zero vector probably because of a degenerate triangle | ||
| if (Cartesian3.equals(Cartesian3.ZERO, normal)) { |
added 2 commits
February 24, 2017 16:48
This was referenced Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where we can't generate correct normals. Triangles are either degenerate or part of coplanar triangles with opposite winding order.
Added tests for both cases.
CC CesiumGS/gltf-pipeline#242