3D Tiles - Added support for batch table hierarchy without parents #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
changed the title
pjcozzi
reviewed
Mar 8, 2017
| return traverseHierarchyMultipleParents(hierarchy, instanceIndex, endConditionCallback); | ||
| } else { |
There was a problem hiding this comment.
Remove else and just return.
|
Sorry, just that comment. |
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3241
Also using new tilesets generated in CesiumGS/3d-tiles-validator#59.
The problem with black see-through models #4872 (comment) is fixed with the updated tilesets.