3D Tiles Cleanup #5461
Merged
3D Tiles Cleanup #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
force-pushed
the
3d-tiles-cleanup
branch
2 times, most recently
from
645a056
to
4ef7868
Compare
pjcozzi
reviewed
Jun 13, 2017
| @@ -67,6 +67,10 @@ defineSuite([ | |||
| scene.primitives.removeAll(); | |||
| }); | |||
|
|
|||
| it ('gets properties', function() { | |||
There was a problem hiding this comment.
Oh, forgot to remove that. Updated now.
|
LGTM Let's aim to merge this today. @mramato do you want to look at this? |
mramato
reviewed
Jun 13, 2017
Source/Scene/Cesium3DTileStyle.js
Outdated
|
|
||
| promise.then(function(styleJson) { | ||
| setup(that, styleJson); | ||
| that._readyPromise.resolve(that); |
There was a problem hiding this comment.
This is redundant, you can just assign this._readyPromise = promise.then.... and avoid using the defer completely. I'll just submit a tweak myself so we can get this merged.
|
I'll admit, I didn't review this rigorously, but it looks good to me. There is a release only test failure for @pjcozzi feel free to merge. |
|
And thanks @lilleyse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on review comments in #5308
I think I got mostly everything here. Will leave more notes on the other PR.