Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse binarygltf with dataView #5812

Closed

Conversation

jbo023
Copy link
Contributor

@jbo023 jbo023 commented Sep 4, 2017

  • change parseBinaryGltf to use DataView instead of TypedArray, so we do not have to copy the TypedArray to assure the correct byte alignment.
  • change Batched/Instanced3DModel3DTileContent to not copy arraybuffer

As discussed in this PR #5784

TODOs

  • Test with glb (Gltf 2.0) Model
  • Check if parseBinaryGltf should be a PR in gltf-pipeline

Also at first I also wanted to change the typedarray copy of the batchTableBinary. But the batchTableBinary needs the correct byte-alignment and i couldn't find any reference in the 3D Tile spec that the batchTableBinary part should be byte aligned. Should this maybe part of the 3D Tiles Spec? Or do i just check the alignment(largest possible datatype) and only copy if its not aligned properly?

@cesium-concierge
Copy link

@jbo023, thanks for the pull request! Maintainers, we have a signed CLA from @jbo023, so you can review this at any time.

I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I noticed that a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version. Once you do, please confirm by commenting on this pull request.

I am a bot who helps you make Cesium awesome! Thanks again.

@mramato
Copy link
Contributor

mramato commented Oct 20, 2017

@lilleyse do you plan on taking a look at this? Seems like a simple enough change.

@hpinkos
Copy link
Contributor

hpinkos commented Jun 25, 2018

@lilleyse is this something we want or should this be closed?

@lilleyse
Copy link
Contributor

Sorry for letting this slide @jbo023.

The fixes are still relevant for more efficiently loading tiles whose glb content is not correctly aligned, but I think we can close - gltf-pipeline is being upgraded to 2.0 soon and includes the fixes to use DataView, and soon we will remove the workarounds to load deprecated 3D Tiles, including removing this alignment workaround. It wasn't part of the list in #5363 but I'll add it.

@lilleyse lilleyse closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants