Add Geometry tile support #6034
Conversation
|
@bagnell, thanks for the pull request! Maintainers, we have a signed CLA from @bagnell, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
| @@ -37,7 +37,7 @@ | |||
| // For more details, see: | |||
| // https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/vector-tiles/TileFormats/VectorData | |||
| var classification = viewer.scene.primitives.add(new Cesium.Cesium3DTileset({ | |||
| url: 'https://beta.cesium.com/api/assets/3394?access_token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiIzZjM4MjljZi0xNTAzLTQ0MzctODhlZi0zOTU3Njg5ODA1Y2QiLCJpZCI6OCwiaWF0IjoxNDgxODI5ODMyfQ.dYlV8_PoXcFNlPHGook5kMzuJMS-Bb9DCMzI1mFVvgE', | |||
| url: 'https://beta.cesium.com/api/assets/3469?access_token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiIzZjM4MjljZi0xNTAzLTQ0MzctODhlZi0zOTU3Njg5ODA1Y2QiLCJpZCI6OCwiaWF0IjoxNDgxODI5ODMyfQ.dYlV8_PoXcFNlPHGook5kMzuJMS-Bb9DCMzI1mFVvgE', | |||
There was a problem hiding this comment.
Can we add an option to use the geometry tile for rendering vs. classification?
Or is it only suitable for classification right now and we will roadmap rendering, e.g., normals, styling, etc. I would be fine with that.
There was a problem hiding this comment.
This is only suitable for classification right now. I would put geometry tile rendering on the roadmap.
| @@ -1,440 +0,0 @@ | |||
| define([ | |||
There was a problem hiding this comment.
I think I am missing something - should these files be deleted? I thought they were used by the b3dm transcode for classification via b3dm.
There was a problem hiding this comment.
The transcode uses Vector3DTilePrimitive which takes buffers and re-batching information.
There was a problem hiding this comment.
I merged in the latest from b3dm-class so you can run the Sandcastle examples.
|
Do you get test failures? I get failures like:
|
|
Otherwise looks good at quick glance. Please update the spec too, of course. |
I don't see any and the Travis tests also passed. |
|
@pjcozzi This should be ready to go. |
|
Looks good! @lilleyse I'm going to merge this (into |
Adds Geometry (boxes, cylinders, etc.) tile support. Removes the same features from Vector tiles. Vector tiles are now just points, polygons, and polylines.