Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workaround for broken tilesets. #6125

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

tfili
Copy link
Contributor

@tfili tfili commented Jan 17, 2018

A bunch of tilesets were generated that have a leading / in front of all URLs in the tileset.json. If the tiles aren't at the root of the domain they will not load anymore. If we find a b3dm file with a leading slash, we test load a tile. If it succeeds we continue on. If it fails, we set this to true so we know to strip the slash when loading tiles.

@cesium-concierge
Copy link

Signed CLA is on file.

@tfili, thanks for the pull request! Maintainers, we have a signed CLA from @tfili, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Jan 17, 2018

Good idea @tfili, I can confirm this works and is probably the best solution we have for maintaining compatibility while allowed correct tilesets to work properly.

@lilleyse Can you please take a look at this to make sure you are okay with it? What should the tail on this be? One year? Forever? What has our plan been for other old things we've changed in the spec or otherwise had to fix?

@tfili if we decide to only keep this for a certain period of time, we should write an issue so we don't forget about it with whatever future date we think we should revisit this.

@mramato
Copy link
Contributor

mramato commented Jan 18, 2018

Talk to @lilleyse offline, he's good with this. He also suggested just removing it at the same time we handle #5363, so I added a comment there, no need to write up a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants