Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New utility object for working with the Cesium ion beta API #6136

Merged
merged 5 commits into from
Jan 19, 2018
Merged

New utility object for working with the Cesium ion beta API #6136

merged 5 commits into from
Jan 19, 2018

Commits on Jan 19, 2018

  1. New utility object for working with the Cesium ion beta API 

    It's marked experimental since ion is still in beta. I also kept the API
surface area low since it's easier to add stuff later rather than take
things out.
    @mramato
    mramato committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    a354bf0 View commit details
    Browse the repository at this point in the history

  2. Update CHANGES

    @mramato
    mramato committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    33a9879 View commit details
    Browse the repository at this point in the history

  3. Changes after review 

    1. Fix an issue with `loadWithXhr` where a retried request would not
have updated settings modified by the retry callback.
2. Clean up specs so that they can't interfere with each other.
3. Break `ionData` into separate properties and simplify some of the logic
as well as add additional comments.
    @mramato
    mramato committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    391b1f8 View commit details
    Browse the repository at this point in the history

  4. Remove accidental console.log 

    Also fix same requestFunction issue with loadImage and loadJsonp that
loadWithXhr had in my last commit.
    @mramato
    mramato committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    508a22b View commit details
    Browse the repository at this point in the history

  5. More fixes for loadXXX retry logic.

    @mramato
    mramato committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    fe92f99 View commit details
    Browse the repository at this point in the history