Support imagery in alternate map projections #7438

likangning93 · 2018-12-23T16:25:04Z

Take 2. See discussion in attempt 1 here.

This PR adds support for imagery in alternate projections, for example, the kind of TMS you would get from throwing a geotiff of LIMA through GDAL2Tiles using the raster profile. There's also some of this stuff hosted online, like in the new Sandcastle:

Reprojection is once again accomplished with a fixed-resolution vertex warp grid that is much less sophisticated than what OpenLayers advertises and might need further discussion.

However, instead of projecting each image into a geographic tile that overlaps its neighbors, we're generating non-overlapping geographic tiles that may draw from 0 or more projected imagery tiles.
This seems to have gotten around most of the craziness in the first attempt.

… files

cesium-concierge · 2018-12-23T16:25:06Z

Thanks for the pull request @likangning93!

✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

Source/Scene/ImageryLayer.js

sodium-bicarbonate · 2019-01-02T01:51:13Z

Source/Scene/ImageryState.js

@@ -15,7 +15,8 @@ define([
        READY : 4,
        FAILED : 5,
        INVALID : 6,
-        PLACEHOLDER : 7
+        PLACEHOLDER : 7,
+        EMPTY : 8


mramato · 2019-01-02T15:53:42Z

@likangning93 would automatically handling imagery servers that support different projections be possible/easy once this is done? See #7435 which shows that ArcGisMapServerImageryProvider should be able to detect other projections and act accordingly, right? (Not for projections MVP, but something we should probably support eventually)

likangning93 · 2019-01-08T16:57:34Z

@likangning93 would automatically handling imagery servers that support different projections be possible/easy once this is done? See #7435 which shows that ArcGisMapServerImageryProvider should be able to detect other projections and act accordingly, right? (Not for projections MVP, but something we should probably support eventually)

I think so? It might be tricky if ArcGisMapServerImageryProvider can't get at a WKT for the projection though, right now everything with projections is assuming WKT is available.

likangning93 · 2019-01-09T13:59:11Z

@bagnell this is ready for a look.

likangning93 · 2019-01-14T16:53:05Z

@bagnell bump

bagnell · 2019-01-15T20:31:41Z

Apps/Sandcastle/gallery/Polar Imagery.html

+    projectedRectangle : new Cesium.Rectangle(-4194304, -4194304, 4194304, 4194304),
+    numberOfLevelZeroTilesX : 2,
+    numberOfLevelZeroTilesY : 2,
+    imageResolution : new Cesium.Cartesian2(512, 512)


imageResolution isn't an option.

bagnell · 2019-01-15T20:31:56Z

Source/Core/ProjectedImageryTilingScheme.js

+     */
+    ProjectedImageryTilingScheme.prototype.getProjectedTilesForNativeTile = function(x, y, level) {
+        var tileRectangle = this.tileXYToRectangle(x, y, level, new Rectangle());
+        var tileProjectedRectangle = Rectangle.approximateProjectedExtents(tileRectangle, this._projection, new Rectangle());


Use scratch variables.

bagnell · 2019-01-15T20:47:03Z

Source/Scene/Imagery.js

+
+        var tilingScheme = this.imageryLayer.imageryProvider.tilingScheme;
+        var singleSource = !(tilingScheme instanceof ProjectedImageryTilingScheme);
+        var imageryLayer = this.imageryLayer;


Move this to the top of the function and replace the other this.imageryLayers.

bagnell · 2019-01-15T20:47:52Z

Source/Scene/Imagery.js

+                    var index = i * 2;
+                    var x = projectedIndices[index];
+                    var y = projectedIndices[index + 1];
+                    this.projectedRectangles[i] = tilingScheme.getProjectedTileProjectedRectangle(x, y, level);


Pass this.projectedRectangles[i] as the result parameter. This way it doesn't always create new Rectangles.

bagnell · 2019-01-15T21:01:38Z

Source/Scene/ImageryLayer.js

+                }
+
+                // Mark discarded imagery tiles invalid.  Parent imagery will be used instead.
+                if (discardPolicy.shouldDiscardImage(projectedImages[0])) {


Could this have a mix of images that should be discarded and some that should not? If so, you should discard the ones that need to be and, if all are discarded, set the state to invalid.

discard the ones that need to be

If only some of the images are discarded do we need to fill in the missing areas using the parent image? Is it too heavy-handed to mark the entire tile as invalid if one of its images is discarded?

If we're filling in, maybe we could grab the parent's reprojected image and copy over select areas. We can use the computed texcoords like a mask but read out of the parent texture using the fragment coordinates and another uniform or something.

grab the parent's reprojected image

There might be complications with this too, if the parent isn't available would we want to go for the nearest ancestor instead? If so, would we want to regenerate the tile when the parent becomes available?

-___-

Those are good questions. Maybe open an issue? What do you think @lilleyse?

Had a discussion offline, we'll just discard the entire "target" tile for now when any of the source images are invalidated. I'll document the behavior.

Source/Scene/ImageryLayer.js

bagnell · 2019-01-15T21:21:30Z

Source/Scene/ImageryLayer.js

        when,
        Imagery,
        ImagerySplitDirection,
        ImageryState,
        TileImagery) {
    'use strict';

+    var ARBITRARY_PROJECTION_VERTICES_WIDTH = 128;


Should these be configurable?

Source/Scene/ImageryLayer.js

bagnell · 2019-01-15T21:35:32Z

Source/Scene/Imagery.js

+                }
+
+                if (projectedTilesLength === 0) {
+                    this.state = ImageryState.EMPTY;


Shouldn't this be marked as invalid instead?

I think if it was INVALID an ancestor would be rendered, but the rendered portion would be entirely transparent so we might as well just not render anything:

What if imagery was requested past the zoom level of the imagery? It should render the ancestor there. Is there a way to tell the difference between this and the case you posted?

Discussed offline, this happens when users don't set a max level and the terrain tile might need an INVALID imagery to upsample correctly. Just looping the state machine when the imagery isn't actually "ready" might cause problems, so I'll replace with INVALID.

bagnell · 2019-01-15T21:45:15Z

Source/Shaders/ReprojectArbitraryFS.glsl

+
+void main()
+{
+    bool inBounds = 0.0 < v_textureCoordinates.x && v_textureCoordinates.x < 1.0 && 0.0 < v_textureCoordinates.y && v_textureCoordinates.y < 1.0;


Should this include 0.0 and 1.0?

…s should be discarded

…l projections

likangning93 · 2019-01-22T21:51:06Z

@bagnell this is up-to-date!

mramato · 2019-01-23T13:36:09Z

It might be better to hold off on merging this until we get the main projection branch into master (since these PRs are related but build on each other as separate features, it would be easier to review projections as-is first.

…tile projected

hpinkos · 2019-09-18T13:52:26Z

@likangning93 what's the plan for this PR?

likangning93 · 2019-09-18T14:03:05Z

what's the plan for this PR?

@mramato?

It wouldn't be ideal, but if nobody has time to review this I can make my peace with closing this unmerged.

hpinkos · 2019-09-18T20:03:57Z

Spoke with @mramato offline, and we're going to leave these open for now and will hopefully be able to finish them up soon

ebogo1 · 2021-09-23T16:09:21Z

At this point the branches are out of date and it'd be a lot of effort to get this PR ready. I'll leave the branch around if we want to look at this again in the future.

likangning93 added 2 commits December 23, 2018 00:59

add reprojected imagery tiles generated from multiple projected image…

30d98fa

… files

style tweak

68cf6e5

likangning93 requested a review from bagnell December 23, 2018 16:25

sodium-bicarbonate reviewed Jan 2, 2019

View reviewed changes

Source/Scene/ImageryLayer.js Show resolved Hide resolved

sodium-bicarbonate reviewed Jan 2, 2019

View reviewed changes

mramato mentioned this pull request Jan 2, 2019

add ArcGisMapServerImageryProvider error #7435

Closed

re-use vertex attributes in between arbitrary imagery projection passes

50e560c

bagnell suggested changes Jan 15, 2019

View reviewed changes

likangning93 added 5 commits January 16, 2019 15:45

small PR comments

6f356b7

cache vertex array when reprojecting imagery from strange projections

fa721cc

remove ImageryState.EMPTY

128f02a

discard entire imagery tile and mark as invalid when any source image…

c1428e9

…s should be discarded

document TileDiscardPolicy behavior with imagery tilesets from unusua…

aa23f49

…l projections

likangning93 added 8 commits February 11, 2019 10:40

Merge branch 'projections' into betterImageryProjection

eaf1e2d

fixes for changes in projections branch

97079b2

add SingleTileProjectedImageryProvider

947e0e6

change Polar Imagery sandcastle to Projected Imagery, include single-…

c7fb815

…tile projected

merge projections into betterImageryProjection and fix conflicts

622ce9a

add limiters for Matrix4Projection

72d1935

Merge branch 'projections' into betterImageryProjection

3bbcc55

merge projections into betterImageryProjection

870ef86

likangning93 mentioned this pull request Aug 20, 2019

Default imagery sampling creates artifact seams #6190

Open

Merge branch 'projections' into betterImageryProjection

5a043b5

ebogo1 closed this Sep 23, 2021

staffordsmith83 mentioned this pull request Sep 5, 2023

Cloud optimised geotiff main TerriaJS/terriajs#6833

Draft

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support imagery in alternate map projections #7438

Support imagery in alternate map projections #7438

likangning93 commented Dec 23, 2018

cesium-concierge commented Dec 23, 2018

sodium-bicarbonate Jan 2, 2019

mramato commented Jan 2, 2019

likangning93 commented Jan 8, 2019

likangning93 commented Jan 9, 2019

likangning93 commented Jan 14, 2019

bagnell Jan 15, 2019

bagnell Jan 15, 2019

bagnell Jan 15, 2019

bagnell Jan 15, 2019

bagnell Jan 15, 2019

likangning93 Jan 16, 2019

likangning93 Jan 16, 2019

bagnell Jan 16, 2019

likangning93 Jan 22, 2019 •

edited

bagnell Jan 15, 2019

bagnell Jan 15, 2019

likangning93 Jan 16, 2019

bagnell Jan 16, 2019

likangning93 Jan 16, 2019

bagnell Jan 15, 2019

likangning93 commented Jan 22, 2019

mramato commented Jan 23, 2019

hpinkos commented Sep 18, 2019

likangning93 commented Sep 18, 2019

hpinkos commented Sep 18, 2019

ebogo1 commented Sep 23, 2021

Support imagery in alternate map projections #7438

Support imagery in alternate map projections #7438

Conversation

likangning93 commented Dec 23, 2018

cesium-concierge commented Dec 23, 2018

Choose a reason for hiding this comment

mramato commented Jan 2, 2019

likangning93 commented Jan 8, 2019

likangning93 commented Jan 9, 2019

likangning93 commented Jan 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

likangning93 Jan 22, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

likangning93 commented Jan 22, 2019

mramato commented Jan 23, 2019

hpinkos commented Sep 18, 2019

likangning93 commented Sep 18, 2019

hpinkos commented Sep 18, 2019

ebogo1 commented Sep 23, 2021

likangning93 Jan 22, 2019 •

edited