Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access_token from gist loading. #8614

Merged
merged 1 commit into from Feb 13, 2020

Conversation

shunter
Copy link
Contributor

@shunter shunter commented Feb 13, 2020

GitHub has deprecated use of access_token in query parameters and is email spamming us nonstop about it. (dozens of emails a day)

Gists can be read anonymously with a rate-limit of 60 requests per hour per client IP address.

Since we stopped using gists for Sandcastle example code two years ago, the gist codepath is only for extremely old examples, so the rate limit is unlikely to be an issue in practice.

Also someone with the credentials for @Cesium-Sandcastle needs to revoke the old access_token and stop the endless deluge of emails. Also note that account is still using an agi.com email address.

Fixes #8593

GitHub has deprecated use of `access_token` in query parameters and is email spamming us nonstop about it.
Gists can be read anonymously with a rate-limit of 60 requests per hour per client IP address.

Since we stopped using gists for Sandcastle example code two years ago, the gist codepath is only for extremely old examples, so the rate limit is unlikely to be an issue in practice.
@cesium-concierge
Copy link

Thanks for the pull request @shunter!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@emackey
Copy link
Contributor

emackey commented Feb 13, 2020

Would anyone mind if we use password-reset to gain access to the account and revoke the token? It's driving us nuts.

@emackey
Copy link
Contributor

emackey commented Feb 13, 2020

Tested loading a gist without a token, it works when you're under the rate limit. Since gists are deprecated anyway, this change shouldn't cause any harm. Merging.

@emackey emackey merged commit b117547 into master Feb 13, 2020
@emackey emackey deleted the removeSandcastleGistAccessToken branch February 13, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sandcastle gists using deprecated API, angering the GitHubs
3 participants