Merge pull request #269 from AnalyticalGraphicsInc/processModelMateri…

…alsCommon-fix `processModelMaterialsCommon` fix
CesiumGS · Apr 26, 2017 · a8a0cc6 · a8a0cc6
2 parents 80913b9 + a50a005
commit a8a0cc6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,9 @@
 Change Log
 ==========
 
+### 0.1.0-alpha13 - ??
+* Fixed a bug in `processModelMaterialsCommon` that produced out-of-spec technique states.
+
 ### 0.1.0-alpha12 - 2017-04-13
 * Fixed issue with ambient occlusion not working correctly with other stages. [#267](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/267)
 * Fixed handling of binary glTF with special characters. [#253](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/253)

diff --git a/lib/processModelMaterialsCommon.js b/lib/processModelMaterialsCommon.js
@@ -586,8 +586,8 @@ function generateTechnique(gltf, khrMaterialsCommon, lightParameters, optimizeFo
                 WebGLConstants.DEPTH_TEST,
                 WebGLConstants.BLEND
             ],
-            depthMask: false,
             functions: {
+                depthMask : [false],
                 blendEquationSeparate: [
                     WebGLConstants.FUNC_ADD,
                     WebGLConstants.FUNC_ADD