Fix issue with transparent diffuse texture setting the technique state #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcozzi
requested changes
May 20, 2017
lib/addDefaults.js
Outdated
| @@ -347,6 +347,42 @@ function addDefaultTechnique(gltf) { | |||
| } | |||
| } | |||
|
|
|||
| function isTechniqueShared(gltf, techniqueId) { | |||
| var users = 0; | |||
There was a problem hiding this comment.
Nitpick, but references or numberOfReferences would have better semantics.
lib/addDefaults.js
Outdated
| if (materials.hasOwnProperty(materialId)) { | ||
| var material = materials[materialId]; | ||
| if (material.technique === techniqueId) { | ||
| ++users; |
There was a problem hiding this comment.
Why not return early, i.e., return true; when this is > 1, then just always return false; below.
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
addDefaults.enabledDiffuseTransparencyit checks if any materials have a transparent diffuse texture and if so sets the alpha render state for that technique. The problem occurs when multiple materials share the same technique and one transparent texture causes the whole model to be transparent.The solution was to check if the technique has other users, and if so copy the technique before messing with the render state.
Sample models that show the problem are here: https://groups.google.com/forum/#!topic/cesium-dev/4cG1nDU_QwU