Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace istanbul with nyc #291

Merged
merged 3 commits into from
Jun 28, 2017
Merged

Replace istanbul with nyc #291

merged 3 commits into from
Jun 28, 2017

Conversation

ottaviohartman
Copy link
Contributor

Simple switch from Istanbul to nyc for code coverage.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 93.65% when pulling 8e9a1d8 on omh1280:coverage into 8daf4b9 on AnalyticalGraphicsInc:master.

mramato
mramato reviewed Jun 28, 2017
View reviewed changes
.gitignore
@@ -14,3 +14,4 @@ test
specs/data/boxTexturedUnoptimized/output
doc
*.tgz
.nyc_output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to .npmignore as well, thanks.

@ottaviohartman
Copy link
Contributor Author

Done!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 93.65% when pulling c74e0e8 on omh1280:coverage into 1db7d71 on AnalyticalGraphicsInc:master.

@mramato
Copy link
Contributor

mramato commented Jun 28, 2017

Thanks.

@mramato mramato merged commit 104a8df into CesiumGS:master Jun 28, 2017
@ottaviohartman ottaviohartman deleted the coverage branch June 28, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mramato mramato mramato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ottaviohartman @coveralls @mramato