Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for emissive-only materials #366

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Support for emissive-only materials #366

merged 1 commit into from
Apr 27, 2018

Conversation

lilleyse
Copy link
Contributor

@emackey

Same changes as the Cesium PR: CesiumGS/cesium#6501.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 86.077% when pulling 99f8739 on emissive-fix into 666dbc4 on 2.0-cesium.

emackey
emackey approved these changes Apr 27, 2018
View reviewed changes
Copy link

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I don't have merge access here. But this diff matches the one that got merged to Cesium, so go for it.

@lilleyse lilleyse merged commit c49ccfb into 2.0-cesium Apr 27, 2018
@lilleyse lilleyse deleted the emissive-fix branch April 27, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emackey emackey emackey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilleyse @coveralls @emackey