Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when updating component type for accessors #418

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Fix error when updating component type for accessors #418

merged 2 commits into from
Aug 20, 2018

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Aug 20, 2018

Additional fix after #406

The accessor's byteOffset needs to be set to 0 for the new buffer.

@ggetz ggetz requested a review from lilleyse August 20, 2018 15:56
@lilleyse
Copy link
Contributor

lilleyse commented Aug 20, 2018 •
edited
Loading

Good catch. Code look good, just update CHANGES.md.

@ggetz
Copy link
Contributor Author

ggetz commented Aug 20, 2018

Thanks @lilleyse, updated!

@lilleyse lilleyse merged commit 2d321b0 into master Aug 20, 2018
@lilleyse lilleyse deleted the fix-accessor-type branch August 20, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilleyse lilleyse Awaiting requested review from lilleyse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggetz @lilleyse