Don't duplicate resources that are referenced multiple times #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lilleyse, any plans to merge it soon and release to |
lilleyse
force-pushed
the
duplicate-resources
branch
from
dc04a9e
to
1d1990e
Compare
|
@likangning93 all images, shaders, buffers now pass through This change handles all your comments and makes #483 (comment) OBE. |
lilleyse
commented
Mar 30, 2020
|
Thanks @lilleyse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
Follow up of #474 which was closed. This has the same basic idea but extends it to work with separate resources.