Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLastChild function should ignore comment node #34

Open
yangxuanxing opened this issue Feb 6, 2018 · 2 comments
Open

getLastChild function should ignore comment node #34

yangxuanxing opened this issue Feb 6, 2018 · 2 comments
Labels
enhancement

Comments

@yangxuanxing
Copy link

clamp.js line: 130

function getLastChild should ignore comment node
@CezaryDanielNowak
Copy link
Owner

CezaryDanielNowak commented Feb 7, 2018 •
edited
Loading

Agree. Besides that I opt for having configurable list of tags to omit: a, span, button, strong, abbr, sub, sup should be there by default.

@CezaryDanielNowak
Copy link
Owner

Inserting comments with react is a bit tricky, but I think I managed to fix your issue @yangxuanxing. Please let me know if it's fixed in 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CezaryDanielNowak @yangxuanxing