Fix bug in PSPKI version check because of which New-SelfsignedCertifi… #31
Conversation
…cateEx is not used
| $PspkiVersion = (Get-Module PSPKI).Version | ||
| if($PSPKIVersion.Major -ieq 3 -And $PspkiVersion.Minor -ieq 2 -And $PspkiVersion.Build -ieq 5) { |
There was a problem hiding this comment.
Notice type here, PSPKIVersion is used instead of PspkiVersion
There was a problem hiding this comment.
Also - when PSPKI latest version is used (3.2.6) - this condition returns false, thus New-SelfsignedCertificate is used instead of New-SelfsignedCertificateEx. Which is a big problem since Service Fabric services fail (with 'failed to read private key from certificate') to start when using a cert that was created via New-SelfsignedCertificate.
|
This entire check cause real mess on Win10, where New-SelfSignedCertificate is exist without installation of PSPKI module and looks like produce wrong certificate (https://stackoverflow.com/questions/39378519/service-fabric-cluster-nodes-cant-get-private-key-from-certificate). |
Code that compares PSPKI version has a bug.
First, there's a typo -PSPKIVersion.Major is used instead of PspkiVersion .Major (PS is case sensetive)
Second, -ieq is not the right comparison operator for a verion.