Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation at wrong location when using a Dialog #25

Closed
asafvaron90 opened this issue Apr 8, 2017 · 11 comments
Closed

Animation at wrong location when using a Dialog #25

asafvaron90 opened this issue Apr 8, 2017 · 11 comments
Assignees
Labels

Comments

@asafvaron90
Copy link

I gave the dialog a specific size approximately in the center of the screen and the shine animation happens on the top left corner of it and the scale+change image color happens normally where the button is located.

I think the fix would be inside showAnim.
rootView.addView(shineView, new ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT));

@dengue8830
Copy link

@asafvaron90 can you share more code? i have the same issue

@asafvaron90
Copy link
Author

asafvaron90 commented May 5, 2017 via email

@asafvaron90
Copy link
Author

myDialog(Activity activity) {
mBtnAddToFavs.init(activity); ---> this is shineButton
}
The class extends a normal Dialog (import android.app.Dialog)
dialog will open in the middle of the screen, but the shine animation will be on the top left side of the screen.

let me know how else I can help

@dengue8830
Copy link

dengue8830 commented May 5, 2017

have you fixed the problem? you wrote something like

rootView.addView(shineView, new ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT));

but i would appreciate more code for that solution

@asafvaron90
Copy link
Author

asafvaron90 commented May 5, 2017 via email

@dengue8830
Copy link

thanks bro

@ChadCSong ChadCSong self-assigned this May 6, 2017
@ChadCSong ChadCSong added the bug label May 6, 2017
@ChadCSong
Copy link
Owner

I will check this problem as soon as quickly.

@ChadCSong
Copy link
Owner

@asafvaron90 @dengue8830 Dialog view is on the top of the content view. So it was actually a bug. I'm trying to find a way to draw animation above dialog now. If you have any idea please tell me, thanks.

@fenggit
Copy link

fenggit commented Jul 19, 2017

can you share more code? i have the same issue

@shdkhan
Copy link

shdkhan commented Oct 30, 2018

In my case I got same issue in some different devices. but i am using in activity. Please share some solution

@ChadCSong
Copy link
Owner

Fix this on 1.0.0 ,pls check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants