Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HuntersKeepers needs a Dark Mode #209

Open
ChaelCodes opened this issue Jan 31, 2021 · 3 comments
Open

HuntersKeepers needs a Dark Mode #209

ChaelCodes opened this issue Jan 31, 2021 · 3 comments

Comments

@ChaelCodes
Copy link
Owner

Describe the bug
HuntersKeepers continues to blind unexpecting stream viewers. Apply a dark mode to the site.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@ChaelCodes ChaelCodes added help wanted Extra attention is needed Needs Research and removed help wanted Extra attention is needed labels Jan 31, 2021
@connorshea
Copy link

FWIW I implemented this with Bulma on vglist by using Bulma's css variables branch https://github.com/jgthms/bulma/tree/css-variables-with-fallback

connorshea/vglist#1501

Not sure how applicable that is for Buefy, though.

@ChaelCodes
Copy link
Owner Author

I'm okay with this being dark mode only, and Buefy does support css variables! Buefy will use custom Bulma values if they're set in application.sass and buefy.css is not imported. That means application.css needs to be converted into an application.sass file though. I like the colors and styles you used. I definitely want to borrow that.

Why did you need the theme in individual components? It seems like the application.scss in vglist already has a media query. Also, it looks like Bulma 0.8.0 supported css vars. Why did you need the fallback branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants