-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aleo: Add CAIP-2 and CAIP-10 specs #90
Conversation
Hello 👋 cc @jonandgon |
@bumblefudge @JonathanConn what work needs to be done to get this merged? I can spend some time improving the PR, but I would like some feedback if you guys have any. Thanks! |
hey @jonandgon there are minor/formatting change requests above as well as content questions I'd love answered (may not need changes depending on the answers, or i may be able to add whatever's missing otherwise), nothing blocking other than that |
Hey @bumblefudge I'm not seeing the change requests / questions, can you send a link to it? Or I may not have view access to it. thank you!! |
#90 ? i am guessing you're seeing these messages via email instead of on github dot com? |
yeah, I'm getting email notifications - but I respond directly on github.com. If you could just resend the comments/questions somehow (screenshots work) I can get the fixes in |
aleo/caip2.md
Outdated
|
||
## Syntax | ||
|
||
The Aleo chain ID is the name of the chain. e.g. `testnet3` or `mainnet` when mainnet is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmm, that's more semantics than syntax. What are valid chain IDs? Are they case-sensitive? Canonically lowercase? Max length? etc etc. A reg-exp never hurts, if it's already specified somewhere.
Terribly sorry, I didn't realize my suggestions were all "pending" because I hadn't "submitted" my review! Mea culpa |
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
@bumblefudge - just addressed all your comments, let me know if there's anything else! |
Hey @jonandgon sorry for the back-and-forth. I'm still a little baffled on the chain identifiers-- how do you know you're on The regexp here is a little unnecessary because if you're just specifying the two valid values, this spec will be out of date when a new public network is launched. More importantly, it does not provide any guidance for validating a private network, if those can be spun up-- usually we ask for a regexp of all possible valid network identifiers, not an ENUM expressed as a regex :D |
ok so I got an update from the Aleo team regarding this. in addition to network identifiers hardcoded into the REST endpoint, the Unfortunately, since there is no official support for local devnets, it's hard to say what the network ID for that would be, but since there is 65535 possible ids, they could easily add one. I will update the spec to reflect this new info. Thanks for the patience! |
annnnddd @bumblefudge the specs have been updated. thank you for the help, and please lmk what else needs to be done! |
Cool, I just added a "contents may shift after mainnet launch" disclaimer to the CAIP-2 profile and it's GTG as far as i'm concerned. one more thumbs up from another CASA reviewer and it's shipped |
@bumblefudge any update from the 2nd reviewer? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me - looking forward to the mainnet launch noted in the CAIP!
This is the start of adding CAIP specs for the Aleo Network. Aleo is a privacy-focused L1 that uses zero-knowledge proofs.