Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: Failed to extract binary. Trying to re-download again #98

Closed
kkomelin opened this issue May 15, 2024 · 8 comments
Closed

MacOS: Failed to extract binary. Trying to re-download again #98

kkomelin opened this issue May 15, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@kkomelin
Copy link
Contributor

Two users reported the same issue on MacOs after running localnet start the first time.
The Github actions for MacOS failed because of the same issue Failed to extract binary. Trying to re-download again

@mario4tier mario4tier added the bug Something isn't working label May 16, 2024
@mario4tier mario4tier self-assigned this May 16, 2024
@mario4tier
Copy link
Member

mario4tier commented May 16, 2024

Summary

Mysten Labs did not include many pre-compiled binaries in the latest 1.25 MacOS assets.

Workaround

Users can force Suibase to download/install a specific version with a change to suibase.yaml. Example to force localnet to stay on the last known version working:

force_tag: "devnet-v1.24.0"

Details

Comparison of 1.24 vs 1.25 released assets.

Screenshot from 2024-05-15 23-40-53

Suibase detects that some required binaries are missing and fails.

I will contact Mysten Labs. This might be a temporary glitch.

@mario4tier
Copy link
Member

For a list of tags that can be specified in suibase.yaml:
https://github.com/MystenLabs/sui/releases

@mario4tier
Copy link
Member

mario4tier commented May 16, 2024

Issue now open with Mysten Labs:
MystenLabs/sui#17770

===

For better user experience in the future, I am considering to implement the following logic:

If the download of the latest succeed but the required binaries are not present, then Suibase will fallback to the previous version (unless being forced in suibase.yaml)

@kkomelin
Copy link
Contributor Author

Thank you @mario4tier!

@mario4tier
Copy link
Member

mario4tier commented May 16, 2024

Suibase will now always ignore macos arm64 v1.25 release and download previous version instead:

image

A new function "is_valid_assets" in __globals.sh can be used to hard code more exclusion in the future.

===

If somehow you must use v1.25 on your setup, then specify "precompiled_bin: false" in suibase.yaml to force a cargo build.

@kkomelin
Copy link
Contributor Author

kkomelin commented May 16, 2024

@mario4tier Thank you for the work!
It's a little bit disappointing. Will we exclude more releases in the future? What did Sui guys answered? I can try to reach them out as well if necessary

@mario4tier
Copy link
Member

Mysten has re-release v1.25 with a fix ( MystenLabs/sui#17770 )

I did revert the workaround in Suibase, so everyone should now be able to update to 1.25

@kkomelin Thanks for reporting this.

@kkomelin
Copy link
Contributor Author

Great @mario4tier. Thank you.
That's good news because separate conditions for every buggy version of a dependency could lead the code to a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants