This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
Change misleading log message #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alirezaly
approved these changes
Aug 3, 2020
steviezhang
approved these changes
Aug 3, 2020
ansermino
reviewed
Aug 4, 2020
chains/ethereum/writer_methods.go
Outdated
| @@ -204,7 +204,7 @@ func (w *writer) watchThenExecute(m msg.Message, data []byte, dataHash [32]byte, | |||
| w.executeProposal(m, data, dataHash) | |||
| return | |||
| } else { | |||
| w.log.Trace("Ignoring finalization event", "src", sourceId, "nonce", depositNonce) | |||
| w.log.Trace("Did not find the matching finalization event, retrying...", "src", sourceId, "nonce", depositNonce) | |||
There was a problem hiding this comment.
Suggested change
| w.log.Trace("Did not find the matching finalization event, retrying...", "src", sourceId, "nonce", depositNonce) | |
| w.log.Trace("Ignoring event, not a finalization event", "src", sourceId, "nonce", depositNonce) |
There was a problem hiding this comment.
As I said in the issue, they aren't finalization events and they should still be ignored
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes: #478