This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
Update metrics #525
Merged
Update metrics #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansermino
force-pushed
the
david/update-metrics
branch
from
97c0d49
to
b7a318e
Compare
lastperson
approved these changes
Sep 29, 2020
Co-authored-by: Oleksii Matiiasevych <lastperson@gmail.com>
steviezhang
approved these changes
Sep 29, 2020
steviezhang
reviewed
Sep 29, 2020
| @@ -163,13 +167,15 @@ func (l *listener) pollBlocks() error { | |||
| l.log.Error("Failed to write to blockstore", "err", err) | |||
| } | |||
|
|
|||
| if l.metrics != nil { | |||
| l.metrics.BlocksProcessed.Inc() | |||
There was a problem hiding this comment.
Just a Q, if we were to need to reprocess blocks for some reason this counter could theoretically be larger than the latest processed block metric right?
There was a problem hiding this comment.
Yup! The blocks processed counter will also reset to 0 on restarts.
There was a problem hiding this comment.
do you think it might make more sense to specify that this is the blocks processed in a given "session" then in the docs? (votes submitted as well)
There was a problem hiding this comment.
Not really, this is almost always the case with counters such as this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes: #?