Skip to content
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.

bug with zero blockconfrimations config fix #594

Merged
merged 4 commits into from
Feb 17, 2021
Merged

bug with zero blockconfrimations config fix #594

merged 4 commits into from
Feb 17, 2021

Conversation

P1sar
Copy link
Member

@P1sar P1sar commented Feb 17, 2021

Changes

  • parseChainConfig function fix. When no blockConfirmation opt specified, default value (10) will be used
  • Add unit test to test behaviour

Closes: #?

@P1sar P1sar added the bug label Feb 17, 2021
@P1sar P1sar requested a review from ansermino February 17, 2021 12:07
@ansermino ansermino changed the title bug with zerlo blockconfrimations config fix bug with zero blockconfrimations config fix Feb 17, 2021
@ansermino ansermino merged commit 525be88 into main Feb 17, 2021
@ansermino ansermino deleted the p1sar/bug/default-blockConfrimations-notused branch February 17, 2021 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansermino ansermino ansermino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@P1sar @ansermino