Skip to content
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.

1559 Txs #690

Merged
merged 10 commits into from
Aug 4, 2021
Merged

1559 Txs #690

merged 10 commits into from
Aug 4, 2021

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Aug 2, 2021

Description

I added in the logic for checking whether the chain has forked to London and sending with the appropriate gas price. LockAndUpdateOpts tests whether the header of the most recent block has BaseFee != nil to tell whether we are using London txs. This then updates the GasTipCap and GasFeeCap. GasFeeCap is then used to later when generating a new tx to see whether it should be a LegacyTx or a DynamicFeeTx.

There is also a dependency upgrade for go-ethereum to v1.10.6

Related Issue Or Context

Example transfer submitted on Goerli can be found here: https://goerli.etherscan.io/tx/0x2b090b74e298434bc9023689060b73787f126b1d511ba7ff375aa51b006605c4

Under TX Type you can see EIP-1559 tx type is used.

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

connections/ethereum/connection.go Show resolved Hide resolved
connections/ethereum/connection.go Show resolved Hide resolved
connections/ethereum/connection.go Outdated Show resolved Hide resolved
@GregTheGreek
Copy link
Member

Go aside, the logic makes sense. Also for reference this is what we do in web3.js

@P1sar P1sar merged commit 340decd into main Aug 4, 2021
@P1sar P1sar deleted the maxim/1559-txs branch August 4, 2021 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants