Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http client metrics #325

Merged
merged 11 commits into from
Dec 10, 2020
Merged

Http client metrics #325

merged 11 commits into from
Dec 10, 2020

Conversation

BeroBurny
Copy link
Collaborator

closes #5

@BeroBurny BeroBurny self-assigned this Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020 •
edited

Codecov Report

Merging #325 (c346954) into master (2cbbfa0) will increase coverage by 0.09%.
The diff coverage is 56.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   55.08%   55.17%   +0.09%     
==========================================
  Files          53       56       +3     
  Lines         875      917      +42     
  Branches      105      108       +3     
==========================================
+ Hits          482      506      +24     
- Misses        371      389      +18     
  Partials       22       22
Flag Coverage Δ
unit 55.17% <56.09%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/renderer/models/networkMetrics.ts 7.14% <7.14%> (ø)
...rer/services/db/api/repositories/networkMetrics.ts 73.68% <73.68%> (ø)
src/renderer/models/types/networkMetrics.ts 100.00% <100.00%> (ø)
src/renderer/services/db/api/database.ts 100.00% <100.00%> (ø)
src/renderer/services/db/schema.ts 100.00% <100.00%> (ø)
...nderer/services/validation/rules/password/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbbfa0...c346954. Read the comment docs.

mpetrunic
mpetrunic reviewed Dec 2, 2020
View reviewed changes
src/renderer/models/networkLogs.ts Outdated Show resolved Hide resolved
src/renderer/services/api/http/httpClient.ts Outdated Show resolved Hide resolved
mpetrunic
mpetrunic reviewed Dec 8, 2020
View reviewed changes
src/renderer/models/types/networkMetrics.ts Outdated

export const NetworkMetricsType = new ContainerType<NetworkMetrics>({
fields: {
records: new CompositeArrayType({elementType: NetworkMetricType}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this works.
CompositeArrayType doesn't have deserialize/serialize correctly implemented.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can return back to List and open an issue to optimize this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue at #348

@BeroBurny BeroBurny merged commit 8a6cf2a into master Dec 10, 2020
@BeroBurny BeroBurny deleted the http-client-metrics branch December 10, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@morrigan morrigan Awaiting requested review from morrigan

Assignees

@BeroBurny BeroBurny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics to http client
2 participants
@BeroBurny @mpetrunic