Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env variables and sentry source upload #402

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

mpetrunic
Copy link
Member

  • add env variable replacement during build
  • add sentry plugin for sourcemap upload
  • remove type and eslint checking in webpack

@morrigan Can you take a detail look and set required secrets.

resolves #399

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #402 (7004cb1) into master (318f11f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   58.29%   58.29%           
=======================================
  Files          69       69           
  Lines        1091     1091           
  Branches      125      125           
=======================================
  Hits          636      636           
  Misses        431      431           
  Partials       24       24           
Flag Coverage Δ
unit 58.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318f11f...1741655. Read the comment docs.

@morrigan
Copy link
Member

morrigan commented Jan 7, 2021

I've already set the secrets because using them in my draft PR so check to align that.

@mpetrunic
Copy link
Member Author

I've already set the secrets because using them in my draft PR so check to align that.

there is only sentry dns from what I saw

})
}),
new webpack.DefinePlugin({
"process.env.DOCKER_LIGHTHOUSE_IMAGE": JSON.stringify(process.env.DOCKER_LIGHTHOUSE_IMAGE || "sigp/lighthouse:v1.0.5")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use sigp/lighthouse:latest verzion 1.0.5 could be deprecated in few months

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, double edged sword :D
We can let users do "docker pull" if update is needed. To me looks better to be on stable version that's working for us

@BeroBurny
Copy link
Collaborator

probably this package will help in maintenance https://www.npmjs.com/package/dotenv-webpack

Copy link
Member

@morrigan morrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added auth secret

@mpetrunic mpetrunic merged commit 0b866fb into master Jan 7, 2021
@mpetrunic mpetrunic deleted the mpetrunic/sentry-sourcemap branch January 7, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate and upload sourcemaps to Sentry
3 participants