-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix env variables and sentry source upload #402
Conversation
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 69 69
Lines 1091 1091
Branches 125 125
=======================================
Hits 636 636
Misses 431 431
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I've already set the secrets because using them in my draft PR so check to align that. |
there is only sentry dns from what I saw |
}) | ||
}), | ||
new webpack.DefinePlugin({ | ||
"process.env.DOCKER_LIGHTHOUSE_IMAGE": JSON.stringify(process.env.DOCKER_LIGHTHOUSE_IMAGE || "sigp/lighthouse:v1.0.5") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use sigp/lighthouse:latest
verzion 1.0.5
could be deprecated in few months
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, double edged sword :D
We can let users do "docker pull" if update is needed. To me looks better to be on stable version that's working for us
probably this package will help in maintenance https://www.npmjs.com/package/dotenv-webpack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added auth secret
@morrigan Can you take a detail look and set required secrets.
resolves #399