Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log locations #580

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Fix log locations #580

merged 2 commits into from
Aug 9, 2021

Conversation

BeroBurny
Copy link
Collaborator

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Changes

  • change default path for beacon node data
  • fix mac os logs folder navigation

@BeroBurny BeroBurny added the bug Something isn't working label Aug 9, 2021
@BeroBurny BeroBurny requested review from morrigan, mpetrunic and a team August 9, 2021 06:54
@BeroBurny BeroBurny self-assigned this Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #580 (245d321) into develop (c6eeab1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #580   +/-   ##
========================================
  Coverage    48.17%   48.17%           
========================================
  Files          117      117           
  Lines         2115     2115           
  Branches       231      231           
========================================
  Hits          1019     1019           
  Misses        1067     1067           
  Partials        29       29           
Flag Coverage Δ
unit 48.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/config/config.ts 41.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6eeab1...245d321. Read the comment docs.

@BeroBurny BeroBurny changed the title Beroburny/fixing Fix locations Aug 9, 2021
@mpetrunic mpetrunic changed the title Fix locations Fix log locations Aug 9, 2021
@mpetrunic mpetrunic merged commit fa8f903 into develop Aug 9, 2021
@mpetrunic mpetrunic deleted the beroburny/fixing branch August 9, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants