Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon Node Version #581

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Beacon Node Version #581

merged 5 commits into from
Aug 11, 2021

Conversation

BeroBurny
Copy link
Collaborator

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

image

Issues

Closes #578

@BeroBurny BeroBurny added the enhancement New feature or request label Aug 9, 2021
@BeroBurny BeroBurny requested review from morrigan, mpetrunic and a team August 9, 2021 08:14
@BeroBurny BeroBurny self-assigned this Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #581 (b15aae6) into develop (fa8f903) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #581   +/-   ##
========================================
  Coverage    48.17%   48.18%           
========================================
  Files          117      117           
  Lines         2115     2117    +2     
  Branches       231      231           
========================================
+ Hits          1019     1020    +1     
- Misses        1067     1068    +1     
  Partials        29       29           
Flag Coverage Δ
unit 48.18% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/renderer/services/eth2/client/utils.ts 25.00% <50.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8f903...b15aae6. Read the comment docs.

Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add label indicating that "Pyrmont" is network?

@BeroBurny BeroBurny merged commit af0248b into develop Aug 11, 2021
@BeroBurny BeroBurny deleted the beroburny/bn-version branch August 11, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants