Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodestar update #586

Merged
merged 28 commits into from
Sep 27, 2021
Merged

Lodestar update #586

merged 28 commits into from
Sep 27, 2021

Conversation

BeroBurny
Copy link
Collaborator

@BeroBurny BeroBurny commented Sep 6, 2021

Short description of work done

Update Lodestar package to the latest version and refactor everything need to support it

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Issues

Closes #583

Progress

  • Update lodestar packages
  • Refactor lodestar client
  • Refactor E2E tests
  • Refactor Intregration tests
    • Lighthouse
    • Teku
    • Numbus
      • seems nimbus works but test arent consistent
    • Prysm
      • unable to run local container

@BeroBurny BeroBurny added the dependencies Pull requests that update a dependency file label Sep 6, 2021
@BeroBurny BeroBurny self-assigned this Sep 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #586 (7a60f2c) into develop (7946b72) will increase coverage by 2.30%.
The diff coverage is 29.67%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #586      +/-   ##
===========================================
+ Coverage    47.97%   50.28%   +2.30%     
===========================================
  Files          117      110       -7     
  Lines         2126     1951     -175     
  Branches       231      228       -3     
===========================================
- Hits          1020      981      -39     
+ Misses        1077      941     -136     
  Partials        29       29              
Flag Coverage Δ
unit 50.28% <29.67%> (+2.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/renderer/ducks/validator/slice.ts 13.33% <ø> (ø)
src/renderer/models/beaconNode.ts 9.09% <ø> (ø)
src/renderer/services/api/http/httpClient.ts 13.15% <0.00%> (ø)
src/renderer/services/eth2/client/prysm/index.ts 50.00% <0.00%> (ø)
...services/eth2/client/prysm/CgPrysmEth2EventsApi.ts 15.15% <9.67%> (-8.99%) ⬇️
...vices/eth2/client/eth2ApiClient/CgEth2BeaconApi.ts 9.75% <9.75%> (ø)
...rvices/eth2/client/nimbus/CgNimbusEth2EventsApi.ts 8.57% <15.38%> (ø)
...vices/eth2/client/eth2ApiClient/CgEth2EventsApi.ts 16.12% <16.12%> (ø)
...es/eth2/client/eth2ApiClient/CgEth2ValidatorApi.ts 16.66% <16.66%> (ø)
...ces/eth2/client/eth2ApiClient/CgEth2LodestarApi.ts 18.18% <18.18%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7946b72...7a60f2c. Read the comment docs.

# Conflicts:
#	src/renderer/ducks/beacon/sagas.ts
#	src/renderer/services/api/http/httpClient.ts
#	src/renderer/services/eth2/client/eth2ApiClient/cgEth2BeaconStateApi.ts
#	src/renderer/services/eth2/client/interface.ts
@BeroBurny BeroBurny merged commit 7c60f75 into develop Sep 27, 2021
@BeroBurny BeroBurny deleted the beroburny/lodestar-update branch September 27, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants