feat(rebuild): functions with unit tests #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkeil
changed the title
g11tech
reviewed
Jul 11, 2023
g11tech
reviewed
Jul 11, 2023
g11tech
reviewed
Jul 11, 2023
g11tech
reviewed
Jul 12, 2023
g11tech
reviewed
Aug 1, 2023
g11tech
reviewed
Aug 1, 2023
| }); | ||
| it("should be able to keyValidate PublicKey", () => { | ||
| const agg = aggregatePublicKeys(keys); | ||
| expect(agg.keyValidate()).to.be.undefined; |
There was a problem hiding this comment.
key validate would through on invalid ? in that case check for not throw
There was a problem hiding this comment.
It is impossible to deserialize an invalid PublicKey with the blst library. It will throw when creating the point before aggregation. I added an error check for invalid key though. Will that work?
g11tech
reviewed
Aug 1, 2023
g11tech
reviewed
Aug 1, 2023
matthewkeil
changed the base branch from
mkeil/rebuild-sync-pki
to
mkeil/rebuild
feat(rebuild): fixes from implementation into lodestar
test(rebuild): add spec tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync and Async version of rebuilt functions. No helper classes were used.
How to test
cd rebuild yarn yarn test:unit