test(spec): SecretKey.sign #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
g11tech
reviewed
May 16, 2023
| @@ -68,6 +68,7 @@ typedef enum | |||
| class BlstBase | |||
| { | |||
| public: | |||
| bool IsZeroBytes(const uint8_t *data, size_t start_byte, size_t byte_length); | |||
There was a problem hiding this comment.
what is the reason behind the signature change?
|
closed with preference for macros instead of class based constructs. see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #88 and covers spec testing of the
signmethod onSecretKeyinstances.Inclusions
signHow to test
NOTE: to build and test copy the
blstfolder intorebuild/deps/blst. This will go away when we merge but for nownode-gypgets heartburn when building deps in folder above thebinding.gypfileUnit tests are provided and should have 100% coverage. If you see an edge that may not be covered please feel free to bring it up and I will add the test case
cd rebuild yarn yarn build yarn test:spec