Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Add fee #107

Merged
merged 7 commits into from
Apr 29, 2020
Merged

Add fee #107

merged 7 commits into from
Apr 29, 2020

Conversation

GregTheGreek
Copy link
Member

@GregTheGreek GregTheGreek commented Apr 27, 2020

Changes

  • Adds a fee to be charged when a deposit is made

Closes: #?

@GregTheGreek GregTheGreek changed the title update contract Add fee Apr 27, 2020
@GregTheGreek GregTheGreek force-pushed the greg/add-fee branch 2 times, most recently from ba9d20d to ca239a2 Compare April 27, 2020 22:12
@GregTheGreek GregTheGreek marked this pull request as ready for review April 27, 2020 23:38
@GregTheGreek GregTheGreek requested review from steviezhang, ansermino and spacesailor24 and removed request for steviezhang April 27, 2020 23:39
@@ -213,4 +224,10 @@ contract Bridge is Pausable, AccessControl {
proposal._status = ProposalStatus.Transferred;
emit ProposalExecuted(originChainID, _chainID, depositNonce);
}

function transferFunds(address payable[] memory addrs, uint[] memory amounts) public onlyAdmin {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collected fee needs to go somewhere, this function allows the admin to distribute the fee

@ansermino ansermino merged commit 7dab404 into master Apr 29, 2020
@ansermino ansermino deleted the greg/add-fee branch April 29, 2020 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants