fix: args overwrite (#240)

* fix: args overwrite * fix order * update args
ChainSafe · Jan 12, 2023 · 0a8d442 · 0a8d442
1 parent 18c8232
commit 0a8d442
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/setup/playwright.ts b/src/setup/playwright.ts
@@ -18,14 +18,14 @@ export async function launchPlaywright(
     browser = await (
       await import("playwright")
     ).chromium.launchPersistentContext(tmpdir, {
+      ...(options.playwrightOptions ?? {}),
       headless: options.playwrightOptions?.headless,
       args: [
         `--disable-extensions-except=${metamaskPath}`,
         `--load-extension=${metamaskPath}`,
         ...(options.playwrightOptions?.args || []),
-        `${options.puppeteerOptions?.headless ? "--headless=chrome" : ""}`,
+        ...(options.puppeteerOptions?.headless ? ["--headless=chrome"] : []),
       ],
-      ...(options.playwrightOptions ?? {}),
     });
   }
   const { DPlaywrightBrowser } = await import("../playwright");

diff --git a/src/setup/puppeteer.ts b/src/setup/puppeteer.ts
@@ -8,14 +8,14 @@ export async function launchPuppeteer(
   const pBrowser = await (
     await import("puppeteer")
   ).default.launch({
+    ...(options.puppeteerOptions ?? {}),
     headless: options.puppeteerOptions?.headless,
     args: [
       `--disable-extensions-except=${metamaskPath}`,
       `--load-extension=${metamaskPath}`,
       ...(options.puppeteerOptions?.args || []),
-      `${options.puppeteerOptions?.headless ? "--headless=chrome" : ""}`,
+      ...(options.puppeteerOptions?.headless ? ["--headless=chrome"] : []),
     ],
-    ...(options.puppeteerOptions ?? {}),
   });
   const { DPuppeteerBrowser } = await import("../puppeteer");
   return new DPuppeteerBrowser(pBrowser, options.metaMaskFlask);