address comments

test/basic.spec.ts

@@ -22,6 +22,7 @@ import {
   signLongTypedData,
   signShortTypedData,
 } from "./testPageFunctions";
+import { isUserDataTest } from "./utils/utils";
 
 use(chaiAsPromised);
 
@@ -31,7 +32,7 @@ describe("basic interactions", function () {
   let metaMaskPage: DappeteerPage;
 
   before(async function (this: TestContext) {
-    if (Boolean(process.env.USER_DATA_TEST) === true) {
+    if (isUserDataTest()) {
       this.skip();
     }
 

test/contract.spec.ts

@@ -10,14 +10,15 @@ import { ContractInfo } from "./contract/contractInfo";
 import { TestContract } from "./deploy";
 
 import { requestAccounts, sendTx } from "./testPageFunctions";
+import { isUserDataTest } from "./utils/utils";
 
 describe("contract interactions", function () {
   let contract: TestContract;
   let testPage: DappeteerPage;
   let metamask: Dappeteer;
 
   before(async function (this: TestContext) {
-    if (Boolean(process.env.USER_DATA_TEST) === true) {
+    if (isUserDataTest()) {
       this.skip();
     }
 

test/userData.spec.ts

@@ -14,7 +14,7 @@ import {
   SHORT_ACCOUNT_ADDRESS,
   TestContext,
 } from "./constant";
-import { pause } from "./utils/utils";
+import { isUserDataTest, pause } from "./utils/utils";
 
 describe("userData", function () {
   this.timeout(120000);
@@ -28,7 +28,7 @@ describe("userData", function () {
   const headless = true;
 
   beforeEach(function (this: TestContext) {
-    if (Boolean(process.env.USER_DATA_TEST) === false) {
+    if (!isUserDataTest()) {
       this.skip();
     }
   });
@@ -54,9 +54,10 @@ describe("userData", function () {
       // give some pause to store state into files
       await pause(1);
 
-      browser.storeUserData(userDataDir);
+      const isSuccess = browser.storeUserData(userDataDir);
       await browser.close();
 
+      expect(isSuccess).to.be.true;
       expect(isEmpty(userDataDir)).to.be.false;
     });
 
@@ -105,9 +106,10 @@ describe("userData", function () {
       // give some pause to store state into files
       await pause(1);
 
-      browser.storeUserData(userDataDir);
+      const isSuccess = browser.storeUserData(userDataDir);
       await browser.close();
 
+      expect(isSuccess).to.be.true;
       expect(isEmpty(userDataDir)).to.be.false;
     });
 

test/utils/utils.ts

@@ -13,3 +13,7 @@ export async function clickElement(
   const element = await page.$(selector);
   await element.click();
 }
+
+export function isUserDataTest(): boolean {
+  return Boolean(process.env.USER_DATA_TEST);
+}