feat: speedup initializing MetaMask #238

BeroBurny · 2023-01-10T13:20:23Z

Short description of work done
Implement methods to backup user profile data and load the browser from updated data to speed up the initial start time of dappateer

PR Checklist

I have run linter locally
I have run unit and integration tests locally
- Update configuration the newest version (readme and const)
Rebased to master branch / merged master

Closes #120

Fix casing of MetaMask Co-authored-by: Marin Petrunic <marin.petrunic@gmail.com>

* fix: update ganache, fix test depending on goerli * fix: bugs in selectors, less timeout, reorganise structure * update yarn * chore: improve root hooks * try to increase timeout * better ci * add screenshot uploading to ci * fix screenshot name * run screenshot on failed test * fix lint * change viewport * fix tests * fix#123124 * fix tests * whyyyyyyyyyyyyyyyyyyyyyyyyy * please * fix testing dapp * dunno anymore * fix lint * fix typo in selector * update dapp loading * refactor script fetching for `index.html` * fix dam sing test Co-authored-by: Bernard <bero4net@gmail.com>

fix: import-token flakyness

* feat!: update recommended metamask version * implement screenshot helper * implement hide portfolio popup action * implement close what's new modal action * remove obsolete test * fix dappeteer methods broken on update * chore: fix lint * update metamask version to `10.20.0` * fix addToken.ts * address issues * fix lint * fix tests * fix #4 * fix non visible buttons Co-authored-by: Bernard Stojanović <bero4net@gmail.com>

* chore: change eslint to chainsafe config * address PR comments * address PR comments * fix tests

feat: add support for installing metamask flaask

* feat: add support for installing metamask flaask * feat: ability to install snaps * fi lint * fix starting a snap * fix snap install Co-authored-by: Bernard <bero4net@gmail.com>

* fix: run all tests, faster check for installed snap * fix condition bug

* Add invokeSnap method; update installSnap method parameter; * adjust invokeSnap method after review * Fix params type in invokeSnap method * update invokeSnap Return type * update invokeSnap with generic params * update test expectation * fix lint

* feat:add ability to accept dialogs (#138) * fix lint * move installSnap, invokeSnap to dappeteer api; add bringToFront call to dialog methods * pair improvements * fix lint * add methods snap * exclude flask tests from global * exclude flask tests from global Co-authored-by: Bernard <bero4net@gmail.com>

* feat!: add playwright support * fix: lint * fix: ci matrix * don't run snap tests on non flask * address PR comments

* pair improvements * fix lint * feat: add notify Snap method * Added getAllNotifications method * go back after getting all notifications * remove timeout * fix post merge errors Co-authored-by: Bernard <bero4net@gmail.com> Co-authored-by: Marin Petrunic <marin.petrunic@gmail.com>

* feat: install snap from local files * fix: installing and invokeing snaps * disable addToken test * disable fail fast * replace binance smart chain

set engines compatibility for 16 and above

* feat!: replaced addTokenMethod * feat: remove add network method

* cache yarn and have lint and build as separate steps * add back yarn.lock * add jobs * fix name

* add test to sign typed data * add a check to see if the sign button is actually disabled * clean up * fix and clean * remove flackyness * lint * fix playwright * add hidden option for pupeteer types waitForSelector * remove reload between tests

…#194) * add retries when confirming prompts with lower timeout * better snap error handling, ability to accept multiple key permissions * bail on first fail * add context to screenshots * remove various random timeouts, add wait for overlay, more retrys * fix lint * increase timeout for loading network and token details * address PR comments * increase timeout * add retry to profile dropdown

* chore: node engine requirements (#184) (#186) set engines compatibility for 16 and above Co-authored-by: Bernard Stojanović <bero4net@gmail.com> * pair improvements * fix lint * feat: add notify Snap method * go back after getting all notifications * remove timeout * wip * Add notification observe method * update test * remove unused code * wip notifiction observer * wip observer based notifications * wip observer based notifications * remove unused dependency * cleanup * fixes after merge * revert method names * clean waitForNotification method * emitter solution - FP * emitter solution - ClassBased * Cleanup class based emitter * fix lint * fixes after merge * remove p-event library * remove eslint comment * update test configuration * return NotificationList from waitForNotification * add getNotificationEmitter method * remove back button Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com> Co-authored-by: Bernard Stojanović <bero4net@gmail.com> Co-authored-by: Marin Petrunic <marin.petrunic@gmail.com>

* sharedConst and signature check * without sharedConst :) * request accounts * request accounts * long typed data * short typed data * add token reject/accept * add network accept/reject * actually verify the lock/unlock * contract interactions * address comment * web3-utils 1.3.4 * addToken and addNetwork use boolean * remove useless wait

* docs * change to metaMask accross the board and use bootstrap in our test * MetaMMMMMMask * snaps methods in API.md * snaps usage in Readme.md * Update README.md Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com> * address comment * add forgotten menu item for initSnapEnv * removing jsdoc Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com>

* docs * change to metaMask accross the board and use bootstrap in our test * MetaMMMMMMask * snaps methods in API.md * snaps usage in Readme.md * init * lint * add dev deps for ganache/console.log to make build pass * Update README.md Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com> * address comment * add forgotten menu item for initSnapEnv * removing jsdoc Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com>

.github/workflows/main.yml

# Conflicts: # .github/workflows/main.yml

Lykhoyda · 2023-01-19T13:46:51Z

src/browser.ts

+
+  getUserDataDirPath(): string;
+
+  storeUserData(destination: string): boolean;


How are we using the boolean returned from the method?

It returns true if success false if fails somewhere
For future proofing and for users

Is it better to throw the error if the data is not stored? Can we assume the case that we can continue even if the method is failed?

test/flask/snaps.spec.ts

mpetrunic and others added 30 commits September 22, 2022 15:47

chore: update CI for unstable branch

4de874a

fix!: casing of MetaMask (#132)

00f9857

Fix casing of MetaMask Co-authored-by: Marin Petrunic <marin.petrunic@gmail.com>

fix: update ganache, fix test depending on goerli (#144)

d18efa4

fix: import token flaky (#149)

c90db41

fix: import-token flakyness

chore: change eslint config to chainsafe shared (#152)

9ab9b4c

* chore: change eslint to chainsafe config * address PR comments * address PR comments * fix tests

feat: add support for installing metamask flask (#153)

07775a7

feat: add support for installing metamask flaask

feat: ability to install snap (#154)

564aa4b

* feat: add support for installing metamask flaask * feat: ability to install snaps * fi lint * fix starting a snap * fix snap install Co-authored-by: Bernard <bero4net@gmail.com>

fix: snap install faster, run all tests (#163)

d1a3ec4

* fix: run all tests, faster check for installed snap * fix condition bug

feat!: add playwright support (#167)

c25c66f

* feat!: add playwright support * fix: lint * fix: ci matrix * don't run snap tests on non flask * address PR comments

Merge remote-tracking branch 'origin/master' into unstable

708c87b

feat: method to bootstrap snap env (#180)

ba9745f

* feat: install snap from local files * fix: installing and invokeing snaps * disable addToken test * disable fail fast * replace binance smart chain

chore: node engine requirements (#184)

b01e8d2

set engines compatibility for 16 and above

chore: remove metamask dir (#185)

d9e4a4c

fix: remove page param from install snap (#188)

a4c2031

feat!: replace outdated methods (#189)

4171ea4

* feat!: replaced addTokenMethod * feat: remove add network method

chore: Ci enhancement (#193)

e382c4c

* cache yarn and have lint and build as separate steps * add back yarn.lock * add jobs * fix name

feat: allow signing typed data (#191)

d63f9e4

* add test to sign typed data * add a check to see if the sign button is actually disabled * clean up * fix and clean * remove flackyness * lint * fix playwright * add hidden option for pupeteer types waitForSelector * remove reload between tests

move temporary user data dir in upper scope

31ca258

implement exporting state and running from a state

ac43675

implement userDataDir for puppeteer

08deead

mpetrunic reviewed Jan 16, 2023

View reviewed changes

.github/workflows/main.yml Outdated Show resolved Hide resolved

BeroBurny added 6 commits January 17, 2023 16:03

fix headless issues whit handling files

8072c86

Merge branch 'master' into beroburny/speedup-init

9fba7d2

improve ci

ce421ef

fix yml

51e4498

fix ci

63651eb

improve ci

0acc1be

BeroBurny marked this pull request as ready for review January 17, 2023 15:49

BeroBurny requested a review from irubido as a code owner January 17, 2023 15:49

irubido previously approved these changes Jan 18, 2023

View reviewed changes

Merge branch 'master' into beroburny/speedup-init

61bc018

# Conflicts: # .github/workflows/main.yml

BeroBurny dismissed irubido’s stale review via 61bc018 January 19, 2023 08:17

fix export

87caf77

BeroBurny requested review from mpetrunic and irubido January 19, 2023 10:23

irubido previously approved these changes Jan 19, 2023

View reviewed changes

Lykhoyda reviewed Jan 19, 2023

View reviewed changes

test/flask/snaps.spec.ts Show resolved Hide resolved

address comments

30f7e66

BeroBurny dismissed irubido’s stale review via 30f7e66 January 19, 2023 14:02

Lykhoyda approved these changes Jan 19, 2023

View reviewed changes

BeroBurny merged commit e32457f into master Jan 20, 2023

BeroBurny deleted the beroburny/speedup-init branch January 20, 2023 08:43

github-actions bot mentioned this pull request Jan 20, 2023

chore(master): release 4.2.0 #250

Merged

This was referenced May 2, 2023

chore(master): release 3.0.0 #318

Closed

chore(master): release 3.0.0 #320

Closed

chore(master): release 3.0.0 #322

Closed

chore(master): release 3.0.0 #324

Closed

chore(master): release 3.0.0 #325

Closed

chore(master): release 5.1.0 #327

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: speedup initializing MetaMask #238

feat: speedup initializing MetaMask #238

BeroBurny commented Jan 10, 2023

Lykhoyda Jan 19, 2023

BeroBurny Jan 19, 2023

Lykhoyda Jan 19, 2023


		getUserDataDirPath(): string;

		storeUserData(destination: string): boolean;

feat: speedup initializing MetaMask #238

feat: speedup initializing MetaMask #238

Conversation

BeroBurny commented Jan 10, 2023

PR Checklist

Lykhoyda Jan 19, 2023

Choose a reason for hiding this comment

BeroBurny Jan 19, 2023

Choose a reason for hiding this comment

Lykhoyda Jan 19, 2023

Choose a reason for hiding this comment