Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deploy post build #93

Merged
merged 3 commits into from
Mar 3, 2023
Merged

chore: deploy post build #93

merged 3 commits into from
Mar 3, 2023

Conversation

mpetrunic
Copy link
Member

Alternative to #89

@kalambet I think this makes more sense for this project as it involves fewer build minutes and less of a wait because you don't have to install and build twice.

@kalambet
Copy link
Member

kalambet commented Mar 3, 2023

@mpetrunic I thought about it before too, but there were two reasons why I initially dismissed it because: (a) not sure if can preserve updating (writing) repo deployments; (b) I wanted to exclude deployment for the draft PRs but leave the CI check. The (b) was not implemented just yet bc I did not check the docs, but tbh same goes with (a) too :)

Do you think it is make sense to preserve deployments and do not deploy to CF Pages on Draft PRs?

@mpetrunic
Copy link
Member Author

@mpetrunic I thought about it before too, but there were two reasons why I initially dismissed it because: (a) not sure if can preserve updating (writing) repo deployments; (b) I wanted to exclude deployment for the draft PRs but leave the CI check. The (b) was not implemented just yet bc I did not check the docs, but tbh same goes with (a) too :)

Do you think it is make sense to preserve deployments and do not deploy to CF Pages on Draft PRs?

Well deployment on its own is "free", and takes very little time 15s. If it's done in a separate job, it's best to cache the build so you avoid reinstalling dependencies and rebuilding.

As for draft, I think you can create if condition that will not execute on draft PRs

mpetrunic and others added 2 commits March 3, 2023 15:50
Co-authored-by: Peter Kalambet <peter@kalambet.dev>
@mpetrunic mpetrunic merged commit 3571645 into main Mar 3, 2023
@mpetrunic mpetrunic deleted the chore/deploy-post-build branch March 3, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants