Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockchain docs and cleanup #1000

Merged
merged 16 commits into from
Feb 9, 2021
Merged

Blockchain docs and cleanup #1000

merged 16 commits into from
Feb 9, 2021

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Updates and adds documentation for everything in ./blockchain
  • Updates tipset interactions to avoid unnecessary computation
  • Removes some unwraps in drand specific logic
  • Removes old EPoStProof and EPoStTicket
  • Limits scope of some unnecessarily exposed types

Can generate and open with:

cargo doc --no-deps --all-features

Reference issue to close (if applicable)

Closes

Other information and links

Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great and will be super helpful, thanks!

@@ -666,7 +682,7 @@ where

let worker_key = resolve_to_key_addr(&state, self.blockstore(), &info.worker)?;

let elligable = self.eligible_to_mine(&address, &tipset.as_ref(), &lbts)?;
let eligible = self.eligible_to_mine(&address, &tipset.as_ref(), &lbts)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elegebel lololol

@austinabell austinabell merged commit 9be446b into main Feb 9, 2021
@austinabell austinabell deleted the austin/docs branch February 9, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants