Clippy "Fix" #1064
Merged
Clippy "Fix" #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Mar 29, 2021
cryptoquick
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Nice! I love how clippy helps make things better over time, even if little surprises like this happen here and there.
@ec2 mind making a tracking issue for correcting this, making a note that we'll fix it when we go to publish packages next?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
make lint. We could fix it, but it would require releasing a bunch of crates, so we should do it the next time we do a round of releases.Reference issue to close (if applicable)
Closes
Other information and links