Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and touch-ups #1074

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Minor fixes and touch-ups #1074

merged 3 commits into from
Apr 21, 2021

Conversation

huitseeker
Copy link
Contributor

While reading the code:

  • Option / Result pattern modifications,
  • Rust edition updates (e.g. -> panic!)
  • classic clippy-like fixes

@huitseeker huitseeker requested a review from a user April 17, 2021 14:26
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

cryptoquick
cryptoquick approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good minor style improvements! I don't see anything here that'd alter behavior significantly.

@ec2 @creativcoder @olibearo I think we should get this merged sooner rather than later. It touches a lot of code and it'd suck if this got stale.

@ec2
Copy link
Member

ec2 commented Apr 20, 2021

It looked good to me. I just need to build and run it to make sure there are no functional regressions. Will do that tonight.

@cryptoquick
Copy link
Contributor

Sounds great, glad you're doing that, @ec2

@ec2 ec2 merged commit bb7034a into ChainSafe:main Apr 21, 2021
@ec2
Copy link
Member

ec2 commented Apr 21, 2021

LGTM. Thanks so much for taking the time to have a gander at Forest <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@ec2 ec2 ec2 approved these changes

@creativcoder creativcoder Awaiting requested review from creativcoder

@connormullett connormullett Awaiting requested review from connormullett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huitseeker @CLAassistant @ec2 @cryptoquick