Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for empty_params #1079

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Remove check for empty_params #1079

merged 2 commits into from
Apr 22, 2021

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Apr 21, 2021

Summary of changes
Changes introduced in this pull request:

  • This was removed before in our V2 Actors code. Not sure how it got reintroduced

Reference issue to close (if applicable)

Closes

Other information and links

@ec2 ec2 requested a review from a user April 21, 2021 13:25
cryptoquick
cryptoquick approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, as long as this doesn't break consensus with mainnet. Can you look into why / how check_empty_params was erroneously reintroduced?

@ec2 ec2 merged commit 77f8495 into main Apr 22, 2021
@ec2 ec2 deleted the ec2/empty_params_fix branch April 22, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@creativcoder creativcoder creativcoder approved these changes

@connormullett connormullett Awaiting requested review from connormullett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ec2 @cryptoquick @creativcoder