Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actors v4 (Network v12) #1087

Merged
merged 28 commits into from
Apr 29, 2021
Merged

Actors v4 (Network v12) #1087

merged 28 commits into from
Apr 29, 2021

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Apr 27, 2021

Summary of changes
Changes introduced in this pull request:

  • Released a bunch of crates and implemented actors v4.

Reference issue to close (if applicable)

Closes

Other information and links

@ec2 ec2 requested a review from a user April 27, 2021 12:12
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, this PR looks like a lot, but I don't see any particularly novel patterns, just a few refinements, and the majority of it is just boilerplate stuff that'd have to be updated in any hard fork. Thanks for taking care of this, @ec2 !

Copy link
Contributor

@connormullett connormullett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ec2 ec2 merged commit 3474071 into main Apr 29, 2021
@ec2 ec2 deleted the ec2/actors-v4-impl branch April 29, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants