Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up submit_windowed_post() #1099

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

kirk-baird
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Fixed outdated comments see this PR
  • Adjusted code to match Lotus more cleanly (there is no functional change just reads cleaner)

Reference issue to close (if applicable)

Closes n/a

Other information and links

@CLAassistant
Copy link

CLAassistant commented May 12, 2021

CLA assistant check
All committers have signed the CLA.

@kirk-baird
Copy link
Contributor Author

Note: cargo clippy fails from files outside of what I touched I believe due to a new version of clippy adding extra conditions.

I'm happy to fix it in this commit but don't want to overlap if it's being fixed in another commit.

@ec2
Copy link
Member

ec2 commented May 13, 2021

@kirk-baird That's right, new clippy, new warnings 😵
It was fixed in a recent commit b4215f7
Just pull main into here and the Earth should start rotating again 😄

@kirk-baird
Copy link
Contributor Author

It was fixed in a recent commit b4215f7
Just pull main into here and the Earth should start rotating again

Looks like that commit hasn't been merged into main yet :( and I'm not sure which fork it is on.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kirk 👍

@ec2 ec2 merged commit bd90aa6 into ChainSafe:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants