-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON-RPC Client with FULLNODE_API_INFO config & JWT support #1100
Conversation
…methods are not yet working.
Sprint carryover update I got a lot of good work done during last sprint on implementing the majority of what's needed to fulfill this task. Done
Doing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, will approve once this is R4R if no other changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is RFR, but two things: Errors are not yet parsed correctly, I have an issue upstream for that: I'll also add in some CLI usage examples in the README while y'all are reviewing |
I was just writing this, but then I realized, we should use the
I'm down to merge this without the usage examples changes and the RPC client error parsing if everyone else agrees. |
I can add a note to create some usage examples with my work if needed. You and I understand the CLI enough to be able to work with it. Documentation and usage examples can come once we get a good number of commands running I feel |
@connormullett Yeah, makes sense. I'll make a separate issue for that work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think it may potentially be useful for us to have the CLI be able to also use WS instead of HTTP as an option in the future. Just a thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only did a shallow code review since this already has two approvals, LGTM
I'll make a separate issue for that. It's an entire different transport, so it'd require changes to Multiaddress parsing and some abstraction for a WS client, in addition to surf for HTTP. |
ty :) |
Yes, technically, but since the HTTP and WS server are on the same port, you wont need to change the multiaddr parsing. But yeah there will be some heavy lifting done to abstract the client to handle http and ws. Just an idea i have :) |
…r, but we can solve this in a separate issue.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1084 and #998
Other information and links
Ran into a snag, so still WIP:
kardeiz/jsonrpc-v2#17
Once I get the RPC client working, I'll refactor other RPC methods
The complexity here came from jsonrpsee not supporting: