Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Stack Overflow #1103

Merged
merged 13 commits into from
May 19, 2021
Merged

Resolve Stack Overflow #1103

merged 13 commits into from
May 19, 2021

Conversation

ec2
Copy link
Member

@ec2 ec2 commented May 18, 2021

Summary of changes
Changes introduced in this pull request:

  • Adds a custom global Rayon threadpool so we can easily identify where panics or stack overflows happen in the future for tasks spawned in the global Rayon threadpool
  • We have a minimum on the length that Rayon will split when doing parallel iteration, so that Rayon wont split into too many chunks, which is what was causing the stack overflow.

Reference issue to close (if applicable)

Closes
#869

Other information and links

@ec2 ec2 requested a review from a user May 18, 2021 13:39
@CLAassistant
Copy link

CLAassistant commented May 18, 2021

CLA assistant check
All committers have signed the CLA.

forest/src/daemon.rs Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and trim!

Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I prefer once_cell, but I suppose it's fine if we use both.

@ec2 ec2 merged commit f87d0ba into main May 19, 2021
@ec2 ec2 deleted the ec2/stack-overflow branch May 19, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants